Plugin E2E: Use module nodenext #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
added
patch
1 similar comment
sunker
changed the title
sunker
force-pushed
the
plugin-e2e/ts-node-next
branch
from
b05d0c1
to
a00fde8
Compare
sunker
force-pushed
the
plugin-e2e/ts-node-next
branch
from
ac608e9
to
15a86bf
Compare
sunker
changed the title
grafana-plugins-platform-bot
bot
added
the
released
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Playwright's test-runner does internally determine what kind of fixtures it has to create and load. When using a single variable name without destructing, this is not possible since it needs to load all fixtures. With
nodenextenabled, destructuring assignment is not transpiled to single variables.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @grafana/plugin-e2e@0.0.2-canary.608.ac608e9.0 # or yarn add @grafana/plugin-e2e@0.0.2-canary.608.ac608e9.0